lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 26 Aug 2015 09:48:38 -0700
From: Bill Cox <waywardgeek@...il.com>
To: "discussions@...sword-hashing.net" <discussions@...sword-hashing.net>
Subject: Re: [PHC] Argon2 version 1.2.1 release

Your fix looks good to me.  Minor nit: there are some tabs now that expand
to 8 spaces in my editor, when I think you intended 4.

Bill

On Wed, Aug 26, 2015 at 9:43 AM, Dmitry Khovratovich <khovratovich@...il.com
> wrote:

> Fixed the bug with Argon2_id, should work differently now.
>
> On Wed, Aug 26, 2015 at 5:44 PM, Bill Cox <waywardgeek@...il.com> wrote:
>
>> This looks really good!  Whoever you guys have working on the code did a
>> first rate job.  It is clean and concise at the same time, while being
>> readable and reasonably commented.  I have not yet done an in-depth code
>> review, but from what I've seen so far, it's exactly what I was hoping
>> for.  With this level of quality, Argon2 deserves to win, IMO.
>>
>> However, with new code comes new goobers:
>>
>> - The types Argon2_i, Argon2_d, etc, should be commented in the code.
>> Few programmers will bother reading the documentation, so the code has to
>> be understandable on it's own.  There needs to be some comments to help the
>> programmer decide which to call.
>>
>> - I think the Argon2_id mode is currently equivalent to Argon2_d.
>> There's no place in the reference code where Argon2_id is used.  The reason
>> the vectors are different is probably because the type is hashed into the
>> initial derived key, as it should be.
>>
>> Overall, this seems like outstanding work.  Thanks to everyone in the
>> Argon2 team for delivering a first rate solution!
>>
>> Bill
>>
>
>
>
> --
> Best regards,
> Dmitry Khovratovich
>

Content of type "text/html" skipped

Powered by blists - more mailing lists