linux-ext4 - Re: [PATCH][RFC] vfs: add message print mechanism for the mount/umount into the VFS layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ACB784A.3090604@oracle.com>
Date:	Tue, 06 Oct 2009 10:03:06 -0700
From:	Sunil Mushran <sunil.mushran@...cle.com>
To:	Toshiyuki Okajima <toshi.okajima@...fujitsu.com>
CC:	viro@...iv.linux.org.uk, tytso@....edu,
	linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH][RFC] vfs: add message print mechanism for the mount/umount
 into the VFS layer

Toshiyuki Okajima wrote:
>   	up_write(&namespace_sem);
> +	/* 
> +	 * message output at mount for log observers
> +	 */
> +	if (newmnt->mnt_flags & MNT_VERBOSE_MSG) {
> +		printk(KERN_INFO "Device %s mounted file system type %s read-%s\n",
> +					sb->s_id, sb->s_type->name,
> +					sb->s_flags & MS_RDONLY ? "only" : "write");
> +		/* fs specific messages for mount */
> +		if (sb->s_op != NULL && sb->s_op->mount_msg != NULL)
> +			sb->s_op->mount_msg(sb);
> +	}
>  	return 0;

How about allowing the fs to over-ride the default message? Reduces the 
clutter.
Same on the umount.


+	if (newmnt->mnt_flags & MNT_VERBOSE_MSG) {
+		if (sb->s_op != NULL && sb->s_op->mount_msg != NULL)
+			sb->s_op->mount_msg(sb);
+		else
+			printk(KERN_INFO "Device %s mounted file system type %s read-%s\n",
+				sb->s_id, sb->s_type->name,
+				sb->s_flags & MS_RDONLY ? "only" : "write");
+	}



--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html