linux-ext4 - Re: [PATCH linux-kselftest/test v5] ext4: add kunit test for decoding extended timestamps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191017125553.GE25548@mit.edu>
Date:   Thu, 17 Oct 2019 08:55:53 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Iurii Zaikin <yzaikin@...gle.com>
Cc:     linux-kselftest@...r.kernel.org, linux-ext4@...r.kernel.org,
        skhan@...uxfoundation.org, adilger.kernel@...ger.ca,
        Tim.Bird@...y.com, kunit-dev@...glegroups.com,
        brendanhiggins@...gle.com
Subject: Re: [PATCH linux-kselftest/test v5] ext4: add kunit test for
 decoding extended timestamps

On Wed, Oct 16, 2019 at 01:58:20PM -0700, Iurii Zaikin wrote:
> KUnit tests for decoding extended 64 bit timestamps
> that verify the seconds part of [a/c/m]
> timestamps in ext4 inode structs are decoded correctly.
> KUnit tests, which run on boot and output
> the results to the debug log in TAP format (http://testanything.org/).
> are only useful for kernel devs running KUnit test harness. Not for
> inclusion into a production build.
> Test data is derived from the table under
> Documentation/filesystems/ext4/inodes.rst Inode Timestamps.
> 
> Signed-off-by: Iurii Zaikin <yzaikin@...gle.com>

Reviewed-by: Theodore Ts'o <tytso@....edu>

Minor nit.  The above commit description would look nicer when looked
at in "git log" when formatted as follows:

--- cut here ---

KUnit tests for decoding extended 64 bit timestamps that verify the
seconds part of [a/c/m] timestamps in ext4 inode structs are decoded
correctly.

KUnit tests, which run on boot and output the results to the debug log
in TAP format (http://testanything.org/) are only useful for kernel
devs running KUnit test harness and are not for inclusion into a
production build.

Test data is derived from the table in the Inode Timestamps section of
Documentation/filesystems/ext4/inodes.rst.

--- cut here ---

					- Ted