linux-ext4 - Re: [PATCH] e2fsprogs: fix device name parsing to resolve names containing '='

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 10 Aug 2022 23:18:23 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Lukas Czerner <lczerner@...hat.com>
Cc:     linux-ext4@...r.kernel.org, Daniel Ng <danielng@...gle.com>
Subject: Re: [PATCH] e2fsprogs: fix device name parsing to resolve names
 containing '='

Hi Lukas,

Could you move get_devname() into its own file in lib/support?  e.g.,
create a devname.c and devname.h.

The reason for this is that plausible.c tries to call libmagic via
dlopen() so we don't need to drag libmagic into the minimal package
set for distros.  But that means that any executiables that try to use
devname() will drag in lib/support/pausible.c, which means if you
don't change the makefiles to link in -ldl, static linking will fail:

					- Ted