lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 Aug 2022 09:12:38 +0200 From: Lukas Czerner <lczerner@...hat.com> To: Theodore Ts'o <tytso@....edu> Cc: linux-ext4@...r.kernel.org, Daniel Ng <danielng@...gle.com> Subject: Re: [PATCH] e2fsprogs: fix device name parsing to resolve names containing '=' On Wed, Aug 10, 2022 at 11:18:23PM -0400, Theodore Ts'o wrote: > Hi Lukas, > > Could you move get_devname() into its own file in lib/support? e.g., > create a devname.c and devname.h. > > The reason for this is that plausible.c tries to call libmagic via > dlopen() so we don't need to drag libmagic into the minimal package > set for distros. But that means that any executiables that try to use > devname() will drag in lib/support/pausible.c, which means if you > don't change the makefiles to link in -ldl, static linking will fail: > > - Ted Ah, I didn't notice that. I'll move it into a separate file, devname.[ch] sounds good. Thanks! -Lukas
Powered by blists - more mailing lists