linux-kernel - Re: [PATCH] Add SATA device to VIA IRQ quirk fixup list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Jul 2006 15:31:02 +0100
From:	Daniel Drake <dsd@...too.org>
To:	Sergio Monteiro Basto <sergio@...giomb.no-ip.org>
CC:	Alan Cox <alan@...rguk.ukuu.org.uk>, Andrew Morton <akpm@...l.org>,
	Chris Wedgwood <cw@...f.org>, greg@...ah.com, jeff@...zik.org,
	harmon@....edu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add SATA device to VIA IRQ quirk fixup list

Sergio Monteiro Basto wrote:
> No, Quirks are only need when interrupts are in XT-PIC. (is my bet).
> When APIC and ACPI is enabled (and working) we don't need quirks.
> 
> Someone said on XT-PIC VIA system, don't need, to boot, quirks when ACPI
> is disabled, but this statement don't prove that the quirk aren't need
> it . 

No, please read again:

In the kernels referenced in the bug reports, the quirks were not being 
applied.

When the systems booted up a usual APIC/ACPI config, the hardware in 
question did not work. The quirk was not applied here.

When the system booted up a kernel with acpi=off, the hardware in 
question worked fine. The quirk was not applied here.

When the kernel is modified to apply the quirk again, the system works 
fine in both cases.

IOW, on these systems at least, the quirk is *definitely* needed when 
ACPI/APIC are enabled, whereas in your last mail, you were suggesting we 
should only do the quirk in non-APIC mode:

> I want put here something like:  if ( dev->irq != XT-PIC) return and
> don't quirk this dev.

Such a change would stop the hardware in question from working when 
ACPI/APIC are enabled on these systems.

Daniel

>> http://bugs.gentoo.org/138036
>> http://bugs.gentoo.org/141082

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/