[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <p73lkpf64gh.fsf@verdi.suse.de>
Date: 23 Aug 2006 14:07:10 +0200
From: Andi Kleen <ak@...e.de>
To: Akinobu Mita <mita@...aclelinux.com>
Cc: akpm@...l.org, okuji@...ug.org, Jens Axboe <axboe@...e.de>,
linux-kernel@...r.kernel.org
Subject: Re: [patch 4/5] fail-injection capability for disk IO
Akinobu Mita <mita@...aclelinux.com> writes:
> * @bio: The bio describing the location in memory and on the device.
> @@ -3077,6 +3093,9 @@ end_io:
> if (unlikely(test_bit(QUEUE_FLAG_DEAD, &q->queue_flags)))
> goto end_io;
>
> + if (should_fail(fail_make_request, bio->bi_size))
> + goto end_io;
AFAIK it is reasonably easy to write stacking block drivers.
I think I would prefer a stackable driver instead of this hook.
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists