[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20060823121028.GE5893@suse.de>
Date: Wed, 23 Aug 2006 14:10:28 +0200
From: Jens Axboe <axboe@...e.de>
To: Andi Kleen <ak@...e.de>
Cc: Akinobu Mita <mita@...aclelinux.com>, akpm@...l.org,
okuji@...ug.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 4/5] fail-injection capability for disk IO
On Wed, Aug 23 2006, Andi Kleen wrote:
> Akinobu Mita <mita@...aclelinux.com> writes:
> > * @bio: The bio describing the location in memory and on the device.
> > @@ -3077,6 +3093,9 @@ end_io:
> > if (unlikely(test_bit(QUEUE_FLAG_DEAD, &q->queue_flags)))
> > goto end_io;
> >
> > + if (should_fail(fail_make_request, bio->bi_size))
> > + goto end_io;
>
> AFAIK it is reasonably easy to write stacking block drivers.
> I think I would prefer a stackable driver instead of this hook.
But that makes it more tricky to setup a test, since you have to change
from using /dev/sda (for example) to /dev/stacked-driver.
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists