linux-kernel - Re: [patch 1/5] fail-injection library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <p73hd0364ck.fsf@verdi.suse.de>
Date:	23 Aug 2006 14:09:31 +0200
From:	Andi Kleen <ak@...e.de>
To:	Akinobu Mita <mita@...aclelinux.com>
Cc:	akpm@...l.org, okuji@...ug.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 1/5] fail-injection library

Akinobu Mita <mita@...aclelinux.com> writes:
> +	if (failure_probability(data) == 100 ||
> +	    INT_MAX / 100 * failure_probability(data) > get_random_int())

I don't think it's a good idea to use get_random_int here. It's a secure
quite heavyweight random simulator that eats up precious entropy.

I would use something simple with an option for the user to specify the seed
(default jiffies maybe) for reproducibility.

e.g. the perfmon patchkit that was just posted had a reasonable simple
pseudo RND for lib/. Maybe you can reuse that.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/