linux-kernel - Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061019172948.GA30975@infradead.org>
Date:	Thu, 19 Oct 2006 18:29:49 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Vasily Tarasov <vtaras@...nvz.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>, Jan Kara <jack@...e.cz>,
	Dmitry Mishin <dim@...nvz.org>, Vasily Averin <vvs@...ru>,
	Kirill Korotaev <dev@...nvz.org>,
	OpenVZ Developers List <devel@...nvz.org>
Subject: Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

On Thu, Oct 19, 2006 at 04:32:07PM +0400, Vasily Tarasov wrote:
> +asmlinkage long sys32_quotactl(unsigned int cmd, const char __user *special,
> +						qid_t id, void __user *addr)
> +{
> +	long ret;
> +	unsigned int cmds;
> +	mm_segment_t old_fs;
> +	struct if_dqblk dqblk;
> +	struct if32_dqblk {
> +		__u32 dqb_bhardlimit[2];
> +		__u32 dqb_bsoftlimit[2];
> +		__u32 dqb_curspace[2];
> +		__u32 dqb_ihardlimit[2];
> +		__u32 dqb_isoftlimit[2];
> +		__u32 dqb_curinodes[2];
> +		__u32 dqb_btime[2];
> +		__u32 dqb_itime[2];
> +		__u32 dqb_valid;
> +	} dqblk32;
> +
> +	cmds = cmd >> SUBCMDSHIFT;
> +
> +	switch (cmds) {
> +		case Q_GETQUOTA:
> +			old_fs = get_fs();
> +			set_fs(KERNEL_DS);
> +			ret = sys_quotactl(cmd, special, id, &dqblk);
> +			set_fs(old_fs);

Please allocate the structure using compat_alloc_userspace and copy
with copy_in_user instead of the set_fs trick.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/