linux-kernel - Re: [PATCH 1/4] Prep for paravirt: Be careful about touching BIOS address space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061027144157.f23fcf89.akpm@osdl.org>
Date:	Fri, 27 Oct 2006 14:41:57 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Pavel Machek <pavel@....cz>, Rusty Russell <rusty@...tcorp.com.au>,
	virtualization <virtualization@...ts.osdl.org>,
	lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] Prep for paravirt: Be careful about touching BIOS
 address space

On Fri, 27 Oct 2006 14:31:41 -0700
Jeremy Fitzhardinge <jeremy@...p.org> wrote:

> Pavel Machek wrote:
> > Indentation is b0rken here.
> >   
> 
> Oops.  How strange.
> 
> > And... is get_user right primitive for accessing area that may not be
> > there?
> 
> I'm pretty sure there's precedent for using __get_user in this way 
> (get_user is a different matter, since it cares about whether the 
> address is within the user part of the address space).  Certainly in 
> arch/i386 code there shouldn't be a problem.  Is there some other way to 
> achieve the same effect (without manually setting up an exception/fixup 
> block)?

It'd be better to use include/linux/uaccess.h:probe_kernel_address() for
this operation.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/