linux-kernel - Re: [PATCH 2/20] x86_64: Assembly safe page.h and pgtable.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061118131904.GC17248@in.ibm.com>
Date:	Sat, 18 Nov 2006 08:19:04 -0500
From:	Vivek Goyal <vgoyal@...ibm.com>
To:	Andi Kleen <ak@...e.de>
Cc:	linux kernel mailing list <linux-kernel@...r.kernel.org>,
	Reloc Kernel List <fastboot@...ts.osdl.org>,
	ebiederm@...ssion.com, akpm@...l.org, hpa@...or.com,
	magnus.damm@...il.com, lwang@...hat.com, dzickus@...hat.com,
	pavel@...e.cz, rjw@...k.pl
Subject: Re: [PATCH 2/20] x86_64: Assembly safe page.h and pgtable.h

On Sat, Nov 18, 2006 at 09:49:14AM +0100, Andi Kleen wrote:
> On Friday 17 November 2006 23:37, Vivek Goyal wrote:
> >
> > This patch makes pgtable.h and page.h safe to include
> > in assembly files like head.S.  Allowing us to use
> > symbolic constants instead of hard coded numbers when
> > refering to the page tables.
> 
> I still think that macro is horrible ugly and the use of that
> macro should be minimized as suggested earlier.
> 
Hi Andi,

Personally I think maintenance is easier if we don't try to discriminate
between the constants which require that macro and which don't require.

But if you don't like it, then its ok, I will only apply it to places
where it is really required and breaks the things (like shift operations).

Will do that change in next posting.

Thanks
Vivek
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/