linux-kernel - Re: A CodingStyle suggestion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 3 Feb 2007 13:59:51 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	"Ahmed S. Darwish" <darwish.07@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: A CodingStyle suggestion

On Sat, 3 Feb 2007 23:58:48 +0200 Ahmed S. Darwish wrote:

> Hi all,
> 
> In CodingStyle Chapter 16 "Function return value and names", why not
> adding a comment about the favorable community way of checking the return
> value. ie:
> 
> ret = do_method();
> if (ret) {
>    /* deal with error */
> }
> 
> and not other ways like:
> 
> if (do_method()) or if ((ret = do_method()) > value) ...
> 
> A patch is ready if the replies are positive.

I like it.  Please cc: Andrew Morton <akpm@...l.org> on it.
Hopefully he will merge it.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/