linux-kernel - Re: [PATCH x86 for review III] [10/29] i386: don't include bugs.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070212173523.GB2112@lazybastard.org>
Date:	Mon, 12 Feb 2007 17:35:23 +0000
From:	Jörn Engel <joern@...ybastard.org>
To:	Andi Kleen <ak@...e.de>
Cc:	Andrew Morton <akpm@...l.org>, Andi Kleen <ak@....de>,
	patches@...-64.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH x86 for review III] [10/29] i386: don't include bugs.h

On Mon, 12 February 2007 17:51:30 +0100, Andi Kleen wrote:
> 
> From: Andrew Morton <akpm@...l.org>
> 
> That stupid non-inlined-static function in bugs.h causes:
> 
> include/asm/bugs.h:186: warning: 'check_bugs' defined but not used
> 
> But fortunately the include isn't needed.
> 
> Cc: Andi Kleen <ak@....de>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Andi Kleen <ak@...e.de>
> 
> ---
> 
>  arch/i386/kernel/alternative.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> Index: linux/arch/i386/kernel/alternative.c
> ===================================================================
> --- linux.orig/arch/i386/kernel/alternative.c
> +++ linux/arch/i386/kernel/alternative.c
> @@ -4,7 +4,6 @@
>  #include <linux/list.h>
>  #include <asm/alternative.h>
>  #include <asm/sections.h>
> -#include <asm/bugs.h>
>  
>  static int no_replacement    = 0;
>  static int smp_alt_once      = 0;

Didn't your patchset also include a near-identical patch from Adrian
Bunk (with - and + exchanged)?

Jörn

-- 
Courage is not the absence of fear, but rather the judgement that
something else is more important than fear.
-- Ambrose Redmoon
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/