linux-kernel - Re: [PATCH] aio: propogate post-EIOCBQUEUED errors to completion event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <998821DA-955A-4F4E-A3C5-4BEAE6FFF90B@oracle.com>
Date:	Mon, 19 Feb 2007 16:26:18 -0800
From:	Zach Brown <zach.brown@...cle.com>
To:	Benjamin LaHaise <bcrl@...ck.org>
Cc:	Chris Mason <chris.mason@...cle.com>,
	"Ananiev, Leonid I" <leonid.i.ananiev@...el.com>,
	linux-aio@...ck.org, linux-kernel@...r.kernel.org,
	Suparna bhattacharya <suparna@...ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] aio: propogate post-EIOCBQUEUED errors to completion event

>> I would argue that one common cause of the EIO is userland
>> error (mmap concurrent with O_DIRECT), and EIO is the correct answer.
>
> I disagree.  That means that using the pagecache to synchronize  
> things like
> the proposed online defragmentation will occasionally make O_DIRECT  
> users
> fail.

Well, only if the pages couldn't be invalidated.  Arguably ext3  
should be trying a lot harder to invalidate before giving up and  
returning failure from invalidate_page().

Hopefully this all goes away in the long term with Chris'  
"placeholder" work that stops insertions into the radix tree while  
dio ops are in flight.

- z
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/