linux-kernel - Re: [ckrm-tech] [PATCH 3/3][RFC] Containers: Pagecache controller reclaim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45EEA8DA.6060006@linux.vnet.ibm.com>
Date:	Wed, 07 Mar 2007 17:28:18 +0530
From:	Vaidyanathan Srinivasan <svaidy@...ux.vnet.ibm.com>
To:	Shane <ibm-main@....com.au>
CC:	riel@...hat.com, vatsa@...ibm.com, ckrm-tech@...ts.sourceforge.net,
	balbir@...ibm.com, linux-kernel@...r.kernel.org, xemul@...ru,
	linux-mm@...ck.org, menage@...gle.com, devel@...nvz.org,
	clameter@....com
Subject: Re: [ckrm-tech] [PATCH 3/3][RFC] Containers: Pagecache controller
 reclaim



Shane wrote:
> On Tue, 2007-03-06 at 16:43 +0530, Vaidyanathan Srinivasan wrote:
>> Please let me know if so see any problem running the patch.  The
>> patches are against 2.6.20 only since dependent patches are at that level.
> 
> My problem - a bad copy of the patch. It patches o.k.
> However, it fails to compile vmscan. This looks a bit dodgy;
> 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 
> @@ -1470,11 +1494,13 @@ unsigned long shrink_all_memory(unsigned
>         int pass;
>         struct reclaim_state reclaim_state;
>         struct scan_control sc = {
> -               .gfp_mask = GFP_KERNEL,
> +               .gfp_mask = GFdefined(CONFIG_CONTAINER_PAGECACHE_ACCT)
> +P_KERNEL,
> 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 
> I deleted what looks like an over-enthusiastic "copy-and-paste", and it
> compiled o.k.
> Testing continues.

OOPS!! How did it get there!  That is certainly some random mouse
click.  Thanks for pointing that out.

--Vaidy


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/