linux-kernel - Re: [PATCH] kprobes: fix sparse NULL warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070317053708.GA9803@in.ibm.com>
Date:	Sat, 17 Mar 2007 11:07:08 +0530
From:	Ananth N Mavinakayanahalli <ananth@...ibm.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	prasanna@...ibm.com, anil.s.keshavamurthy@...el.com,
	davem@...emloft.net, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kprobes: fix sparse NULL warning

On Fri, Mar 16, 2007 at 06:34:36PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Fix sparse NULL warnings:
> kernel/kprobes.c:915:49: warning: Using plain integer as NULL pointer

Thanks for catching this Randy.
 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
Acked-by: Ananth N Mavinakayanahalli <ananth@...ibm.com>

> ---
>  kernel/kprobes.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- linux-2621-rc4.orig/kernel/kprobes.c
> +++ linux-2621-rc4/kernel/kprobes.c
> @@ -35,6 +35,7 @@
>  #include <linux/hash.h>
>  #include <linux/init.h>
>  #include <linux/slab.h>
> +#include <linux/stddef.h>
>  #include <linux/module.h>
>  #include <linux/moduleloader.h>
>  #include <linux/kallsyms.h>
> @@ -912,7 +913,7 @@ static int __kprobes debugfs_kprobe_init
>  	if (!dir)
>  		return -ENOMEM;
> 
> -	file = debugfs_create_file("list", 0444, dir , 0 ,
> +	file = debugfs_create_file("list", 0444, dir, NULL,
>  				&debugfs_kprobes_operations);
>  	if (!file) {
>  		debugfs_remove(dir);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/