linux-kernel - Re: [PATCH 4/5] swsusp: fix error paths in snapshot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 20 Mar 2007 23:52:44 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Pavel Machek <pavel@....cz>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/5] swsusp: fix error paths in snapshot_open

On Tuesday, 20 March 2007 23:24, Pavel Machek wrote:
> Hi!
> 
> > > > We forget to increase device_available if there's an error in
> > > > snapshot_open(), so the snapshot device cannot be open at all after
> > > > snapshot_open() has returned an error.
> > > 
> > > Actually, this should go to the beggining of series, as it is
> > > (non-critical) bugfix.
> > 
> > Well, yes.
> > 
> > I've just kept the original order.  OTOH, I don't think it's as urgent as to go
> > into 2.6.21 ("been there forever" kind of thing).
> 
> No, it is not urgent enough for 2.6.21... But I have secret plan...
> trying to push bitmaps+non-bugfixes for swsusp to 2.6.23, and have
> swsusp/s2ram stabilize during 2.6.22. Way too much stuff happened in
> 2.6.21 series.

OK by me, but I think we'll have to tell Andrew which patches should wait
for 2.6.23 anyway. ;-)

Rafael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/