lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 31 Mar 2007 23:34:22 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: "Cong WANG" <xiyou.wangcong@...il.com> Cc: linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk Subject: Re: [-mm3 patch]Warning fix: check the return value of kobject_add etc. On Sun, 1 Apr 2007 14:20:46 +0800 "Cong WANG" <xiyou.wangcong@...il.com> wrote: > > > > > Also, please always prepare patches in `patch -p1' form, as per > > http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt, thanks. > > > > > > Sorry. I am confused with this. Does that mean I should make patches > _upon_ the root kernel source directory or first make a copy of the > original source code and then diff against the two dirs? But I was > told that "patches should be based _in_ the root kernel source > directory" and when only one file was modified just to diff it with > the original single file. (See Documentation/SubmittingPatches.) The headers should look like: --- a/arch/cris/kernel/crisksyms.c +++ a/arch/cris/kernel/crisksyms.c I don't know how people do that. One obvious way is to do cd /usr/src diff -u linux-orig/arch/cris/kernel/crisksyms.c linux-new/arch/cris/kernel/crisksyms.c other people probably alter the diff headers. > And should I remake this patch? Sure, but please change it to perform correct error handling first. And test that error handling, if you can. That will involve adding artificial errors. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists