linux-kernel - Re: [PATCH -mm] slub: update cpu after new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0704250824070.24363@schroedinger.engr.sgi.com>
Date:	Wed, 25 Apr 2007 08:29:28 -0700 (PDT)
From:	Christoph Lameter <clameter@....com>
To:	Hugh Dickins <hugh@...itas.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm] slub: update cpu after new_slab()

On Wed, 25 Apr 2007, Hugh Dickins wrote:

> SLUB gave me a NULL pointer dereference in slab_alloc(), in the
> slab_lock(page) of its "Current cpuslab is acceptable" block: cpu
> 1 had been looking at cpu_slab[2], which then went NULL beneath it.
> Since new_slab() may reenable interrupts and sleep (when __GFP_WAIT),
> we may get rescheduled on a different cpu: so need to reevaluate it.

Right. local_irq_save does not switch off preemption as I thought.

Acked-by: Christoph Lameter <clameter@....com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/