linux-kernel - Re: [PATCH/RFC] Fix build failure for drivers/ata/pata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <464459D8.1030305@gmail.com>
Date:	Fri, 11 May 2007 13:56:08 +0200
From:	Tejun Heo <htejun@...il.com>
To:	Tony Breeds <tony@...eyournoodle.com>
CC:	Linux Kernel ML <linux-kernel@...r.kernel.org>,
	Akira Iguchi <akira2.iguchi@...hiba.co.jp>,
	Jeff Garzik <jgarzik@...ox.com>, linux-ide@...r.kernel.org,
	cbe-oss-dev@...abs.org
Subject: Re: [PATCH/RFC] Fix build failure for drivers/ata/pata_scc.c

Tony Breeds wrote:
> The commit d4b2bab4f26345ea1803feb23ea92fbe3f6b77bc added deadline support to
> prereset and reset methods to libbata the pata_scc driver wasn't converted.
> This patch is a naive attempt to bring this driver up to scratch.
> 
> Build failures are:
> drivers/ata/pata_scc.c: In function 'scc_pata_prereset':
> drivers/ata/pata_scc.c:870: error: too few arguments to function 'ata_std_prereset'
> drivers/ata/pata_scc.c: In function 'scc_error_handler':
> drivers/ata/pata_scc.c:916: warning: passing argument 2 of 'ata_bmdma_drive_eh' from incompatible pointer type
> drivers/ata/pata_scc.c:916: warning: passing argument 3 of 'ata_bmdma_drive_eh' from incompatible pointer type
> drivers/ata/pata_scc.c: In function 'scc_pata_prereset':
> drivers/ata/pata_scc.c:871: warning: control reaches end of non-void function
> 
> On a releated note scc_bus_post_reset() is (AFACT) identical to
> ata_bus_post_reset(), would a patch to make ata_bus_post_reset() assesable to
> drivers be accepted?
> 
> 
> Signed-off-by: Tony Breeds <tony@...eyournoodle.com>
> CC: Tejun Heo <htejun@...il.com>
> CC: Akira Iguchi <akira2.iguchi@...hiba.co.jp>
> CC: Jeff Garzik <jgarzik@...ox.com>
> CC: linux-ide@...r.kernel.org

Acked-by: Tejun Heo <htejun@...il.com>

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/