| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <E1HpA1U-0002jQ-00@calista.eckenfels.net> Date: Fri, 18 May 2007 23:30:04 +0200 From: Bernd Eckenfels <ecki@...a.inka.de> To: linux-kernel@...r.kernel.org Subject: Re: aio is unlikely In article <058f01c7998e$1406e370$650df7cd@...BA> you wrote: >> -#define in_aio() !is_sync_wait(current->io_wait) >> +#define in_aio() (unlikely(!is_sync_wait(current->io_wait))) > > Shouldn't unlikely() go where in_aio() is actually used, if we printk(error) > there? Actually I would just remove that define and use the method directly, if this is the only place where it is used. If it is used in multiple places, the unlikely is most likely wrong .) Gruss Bernd - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists