linux-kernel - Re: [patch] sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070525080258.GA21446@elte.hu>
Date:	Fri, 25 May 2007 10:02:58 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Satyam Sharma <satyam.sharma@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] sched_clock(): cleanups


* Andi Kleen <andi@...stfloor.org> wrote:

> Propose a better way to code this then? It's not my fault that dealing 
> with callbacks in C is so messy. _here just massages one callback 
> prototype (smp_call_function's) into another (cpufreq's) because both 
> callbacks do the same in this case.

see the last iteration of the cleanups i did. Naming the function after 
what it does, and prefixing the preempt-unsafe one __ does the trick.

> The r_s_f BTW stands for resync_sc_freq which is a function earlier in 
> the file and should be familiar to a serious reader.

I consider myself a serious reader and it wasnt obvious to me. Names 
must always be descriptive, we cannot hold all the details in our heads 
all the time.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/