[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070730052653.GD26610@linux.vnet.ibm.com>
Date: Sun, 29 Jul 2007 22:26:53 -0700
From: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To: Daniel Walker <dwalker@...sta.com>
Cc: mingo@...e.hu, linux-kernel@...r.kernel.org,
linux-rt-users@...r.kernel.org
Subject: Re: [PATCH -rt 1/9] preempt rcu: check for underflow
On Sun, Jul 29, 2007 at 07:45:35PM -0700, Daniel Walker wrote:
> Simple WARN_ON to catch any underflow in rcu_read_lock_nesting.
>
> Signed-off-by: Daniel Walker <dwalker@...sta.com>
Acked-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> ---
> kernel/rcupreempt.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> Index: linux-2.6.22/kernel/rcupreempt.c
> ===================================================================
> --- linux-2.6.22.orig/kernel/rcupreempt.c
> +++ linux-2.6.22/kernel/rcupreempt.c
> @@ -157,6 +157,12 @@ void __rcu_read_unlock(void)
> }
>
> local_irq_restore(oldirq);
> +
> + /*
> + * If our rcu_read_lock_nesting went negative, likely
> + * something is wrong..
> + */
> + WARN_ON(current->rcu_read_lock_nesting < 0);
> }
>
> static void __rcu_advance_callbacks(void)
>
> --
> -
> To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists