linux-kernel - Re: 2.6.23-rc2-mm2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070810165906.GI18938@stusta.de>
Date:	Fri, 10 Aug 2007 18:59:06 +0200
From:	Adrian Bunk <bunk@...nel.org>
To:	Valdis.Kletnieks@...edu
Cc:	Aurelien Jarno <aurelien@...el32.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: 2.6.23-rc2-mm2

On Fri, Aug 10, 2007 at 12:40:49PM -0400, Valdis.Kletnieks@...edu wrote:
> On Fri, 10 Aug 2007 11:23:34 +0200, Aurelien Jarno said:
> > I have just tried it, and it fails to build for MIPS with the following
> > error:
> > 
> >   CC      arch/mips/kernel/asm-offsets.s
> > In file included from include/linux/sched.h:58,
> >                  from arch/mips/kernel/asm-offsets.c:13:
> > include/linux/mm_types.h:115: error: expected specifier-qualifier-list before 'pgprot_t'
> > include/linux/mm_types.h:169: warning: 'struct file' declared inside parameter list
> > include/linux/mm_types.h:169: warning: its scope is only this definition or declaration, which is probably not what you want
> > include/linux/mm_types.h:175: error: expected specifier-qualifier-list before 'pgd_t'
> > 
> > 
> > The trivial patch below fixes this problem.
> 
> Rather than adding it to an include/linux file, where it then gets dragged
> in on *all* architectures, maybe we should investigate why it dies on MIPS,
> and fix it for *that* arch?

It must be included on *all* architectures, and the architectures where 
asm/page.h wasn't by chance already included indirectly included by some 
other header don't compile.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/