linux-kernel - Re: [PATCH] PCI: nVidia's MCP61 ethernet card needs quirk for wrong class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0710011656090.7567@jikos.suse.cz>
Date:	Mon, 1 Oct 2007 17:01:50 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Jeff Garzik <jgarzik@...ox.com>
Cc:	Greg KH <greg@...ah.com>, Ayaz Abdulla <aabdulla@...dia.com>,
	linux-pci@...ey.karlin.mff.cuni.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: nVidia's MCP61 ethernet card needs quirk for wrong
 class

On Mon, 1 Oct 2007, Jeff Garzik wrote:

> There are other network devices that do not claim 
> PCI_CLASS_NETWORK_ETHERNET either.  

Nor any other PCI_CLASS_NETWORK subclass?

> Since this is a purely cosmetic issue -- said userland tools would need 
> to support weird cases _anyway_ -- I am not inclined to apply the patch.

What would you recommend as a method for userspace to detect whether given 
hardware is a network card, supposing that there is no driver bound to it 
yet?

> The kernel could do a lot to make things "prettier," but that would lead 
> to lots of additional code bloat.  It's easier to export the world as it 
> is, and let the chips fall where they may.

OK, I don't seem to agree with you on this matter, let's wait for Greg's 
oppinion.

Thanks,

-- 
Jiri Kosina
SUSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/