linux-kernel - Re: [PATCH] PCI: nVidia's MCP61 ethernet card needs quirk for wrong class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47010E01.2010001@pobox.com>
Date:	Mon, 01 Oct 2007 11:10:57 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Jiri Kosina <jkosina@...e.cz>
CC:	Greg KH <greg@...ah.com>, Ayaz Abdulla <aabdulla@...dia.com>,
	linux-pci@...ey.karlin.mff.cuni.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: nVidia's MCP61 ethernet card needs quirk for wrong
 class

Jiri Kosina wrote:
> On Mon, 1 Oct 2007, Jeff Garzik wrote:
> 
>> There are other network devices that do not claim 
>> PCI_CLASS_NETWORK_ETHERNET either.  
> 
> Nor any other PCI_CLASS_NETWORK subclass?

Correct.


>> Since this is a purely cosmetic issue -- said userland tools would need 
>> to support weird cases _anyway_ -- I am not inclined to apply the patch.
> 
> What would you recommend as a method for userspace to detect whether given 
> hardware is a network card, supposing that there is no driver bound to it 
> yet?

Note the mention of "weird cases"

You come up with a general method, then you have to deal with exceptions 
to that general method.

Another example:  8139too and 8139cp both claim to support 
(0x10EC,0x8139) PCI IDs.  The distro installer needs additional 
information to know to read the PCI revision, which is what determines 
whether or not to use 8139cp driver.

Sometimes life is just not as simple as you would like it to be :)

	Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/