linux-kernel - Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 5 Dec 2007 16:40:46 -0400
From:	Konrad Rzeszutek <konrad@...nok.org>
To:	Doug Maxey <dwm@...yolf.org>
Cc:	darnok@....org, linux-kernel@...r.kernel.org, pjones@...hat.com,
	konradr@...hat.com, konradr@...ux.vnet.ibm.com, greg@...ah.com,
	randy.dunlap@...cle.com, hpa@...or.com, lenb@...nel.org,
	mike.anderson@...ibm.com, dwm@...tin.ibm.com,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: [REPOST PATCH] Add iSCSI IBFT support (v0.4)

On Wed, Dec 05, 2007 at 02:26:40PM -0600, Doug Maxey wrote:
> 
> On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote:
> > > Is the current include from open-iscsi being duplicated?  If not, why
> > > not consolidate in one file?
> > 
> > The include files that come from open-iscsi that are in the kernel do
> > not have the iBFT data structures in them - therefore no duplication.
> 
> That is strictly true, at least the "in the kernel" part.  There is a 
> file with the definitions, open-iscsi utils/fwparam_ibft/fwparam_ibft.h 
> does have the previous definitons.  So what to do?  Drop that one?  Or 
> keep duplicating?

I would say that utils/fwparam_ibft/fwparam_ibft.h and
utils/fwparam_ibft/fwparam_ibft.c would be dropped once this kernel
patch and the patch to open-iscsi to add fwparam_ibft_subsys.c are
reviewed and hopefully accepted.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/