| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 28 Mar 2008 12:38:03 +0100 From: Andi Kleen <andi@...stfloor.org> To: Jiri Slaby <jirislaby@...il.com> Cc: Andi Kleen <andi@...stfloor.org>, Mauro Carvalho Chehab <mchehab@...radead.org>, Linux and Kernel Video <video4linux-list@...hat.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: v4l & compat_ioctl On Fri, Mar 28, 2008 at 12:31:33PM +0100, Jiri Slaby wrote: > On 03/28/2008 12:25 PM, Andi Kleen wrote: > >However the new standard way to do this is to not > >add new stuff into compat_ioctl.c, but define ->compat_ioctl > >entry points in the low level drivers (and ideally converted > >them to ->unlocked_ioctl too while you're at it) > > Andi, the problem here is, that v4l has only open in fops which in turn > changes fops to the driver's one, so this would mean change all the drivers > in v4l... And? Are there that many? It's a simple mechanical operation. > I second the converting to unlocked_ioctl and compat_ioctl in longer term > (for new drivers as a merging rule), but wouldn't be feasible to add them > to compat ioctl for now? The problem with compat_ioctl is that it doesn't handle overlapping ioctl ranges and that the compat code cannot be made modular (although if they are compatible that is no big problem) BTW i haven't audited them, but if there is u64 or similar in there anywhere be careful about alignment. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists