linux-kernel - Re: [PATCH] xfs: expose no-op xfs_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <480DF158.60909@sandeen.net>
Date:	Tue, 22 Apr 2008 09:08:24 -0500
From:	Eric Sandeen <sandeen@...deen.net>
To:	Denys Vlasenko <vda.linux@...glemail.com>
CC:	David Chinner <dgc@....com>, Adrian Bunk <bunk@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xfs: expose no-op xfs_put_perag()

Denys Vlasenko wrote:
> Hi David,
> 
> Inline function xfs_put_perag() in fs/xfs/xfs_mount.h is a no-op.
> 
> This patch converts it to no-op macro.
> 
> As a result, gcc will emit warning about unused variables,
> parameters and so on not in this function, but in its callers,
> which is more useful.
> 
> This patch, together with previous ones, has already resulted
> in more unused params discovered and warned about by gcc.
> 
> There is no object code size difference from this change.

Denys, thanks for going through all this; I didn't mean to discount the
work with the stackcheck reports.  I've done a lot of similar xfs
pruning in the past, and every little bit helps.  It is still hard to
find significant reductions in the critical callchains though!

If the xfs codebase gets to the point where things are fairly well
cleaned up it might be nice to add the gcc warning to the makefiles, add
unused attributes to the vfs ops vectors as needed, and keep it clean
from this point on...

Thanks,

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/