linux-kernel - [PATCH] SYSFS: Correct misleading documentation in params.c.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 25 Apr 2008 12:46:20 -0400 (EDT)
From:	"Robert P. J. Day" <rpjday@...shcourse.ca>
To:	trivial@...nel.org
cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: [PATCH] SYSFS: Correct misleading documentation in params.c.


A couple comment fixes related to creating module parameter files
under /sys.

Signed-off-by: Robert P. J. Day <rpjday@...shcourse.ca>

---

  i have no idea what means that reference to symlinks to
/sys/parameters.  something long since gone away?

diff --git a/kernel/params.c b/kernel/params.c
index afc46a2..52ac726 100644
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -372,7 +372,7 @@ int param_get_string(char *buffer, struct kernel_param *kp)
 	return strlcpy(buffer, kps->string, kps->maxlen);
 }

-/* sysfs output in /sys/modules/XYZ/parameters/ */
+/* sysfs output in /sys/module/XYZ/parameters/ */

 extern struct kernel_param __start___param[], __stop___param[];

@@ -506,8 +506,7 @@ param_sysfs_setup(struct module_kobject *mk,
  * @kparam: module parameters (array)
  * @num_params: number of module parameters
  *
- * Adds sysfs entries for module parameters, and creates a link from
- * /sys/module/[mod->name]/parameters to /sys/parameters/[mod->name]/
+ * Adds sysfs entries for module parameters.
  */
 int module_param_sysfs_setup(struct module *mod,
 			     struct kernel_param *kparam,
@@ -572,7 +571,7 @@ static void __init kernel_param_sysfs_setup(const char *name,
 }

 /*
- * param_sysfs_builtin - add contents in /sys/parameters for built-in modules
+ * param_sysfs_builtin - add contents under /sys for built-in modules
  *
  * Add module_parameters to sysfs for "modules" built into the kernel.
  *

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/