lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 Apr 2008 18:45:09 +0200 From: Ingo Molnar <mingo@...e.hu> To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Andi Kleen <andi@...stfloor.org>, Jiri Slaby <jirislaby@...il.com>, David Miller <davem@...emloft.net>, zdenek.kabelac@...il.com, rjw@...k.pl, paulmck@...ux.vnet.ibm.com, akpm@...ux-foundation.org, linux-ext4@...r.kernel.org, herbert@...dor.apana.org.au, penberg@...helsinki.fi, clameter@....com, linux-kernel@...r.kernel.org, Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>, pageexec@...email.hu, "H. Peter Anvin" <hpa@...or.com>, Jeremy Fitzhardinge <jeremy@...p.org> Subject: Re: [PATCH 1/1] x86: fix text_poke * Linus Torvalds <torvalds@...ux-foundation.org> wrote: > But there was actually a much worse problem with my patch: > __set_fixmap() is __init. Which means that my patch was just totally > broken. ah, on 64-bit. That we better make consistent anyway, via the patch below. set_pte_phys() needs to become non-init as well. Ingo -----------> Subject: x86: make __set_fixmap() non-init From: Ingo Molnar <mingo@...e.hu> Date: Fri Apr 25 18:28:21 CEST 2008 Signed-off-by: Ingo Molnar <mingo@...e.hu> --- arch/x86/mm/init_64.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) Index: linux/arch/x86/mm/init_64.c =================================================================== --- linux.orig/arch/x86/mm/init_64.c +++ linux/arch/x86/mm/init_64.c @@ -135,7 +135,7 @@ static __init void *spp_getpage(void) return ptr; } -static __init void +static void set_pte_phys(unsigned long vaddr, unsigned long phys, pgprot_t prot) { pgd_t *pgd; @@ -214,8 +214,7 @@ void __init cleanup_highmap(void) } /* NOTE: this is meant to be run only at boot */ -void __init -__set_fixmap(enum fixed_addresses idx, unsigned long phys, pgprot_t prot) +void __set_fixmap(enum fixed_addresses idx, unsigned long phys, pgprot_t prot) { unsigned long address = __fix_to_virt(idx); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists