linux-kernel - Re: [RFC] OpenFirmware bindings for the MMC-over-SPI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa686aa40805242147w400e2ff5jf532f8843ec3f85f@mail.gmail.com>
Date:	Sat, 24 May 2008 22:47:08 -0600
From:	"Grant Likely" <grant.likely@...retlab.ca>
To:	"David Brownell" <david-b@...bell.net>
Cc:	avorontsov@...mvista.com, "Pierre Ossman" <drzeus-mmc@...eus.cx>,
	"David Brownell" <dbrownell@...rs.sourceforge.net>,
	"Gary Jennejohn" <garyj@...x.de>,
	"Guennadi Liakhovetski" <g.liakhovetski@....de>,
	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC] OpenFirmware bindings for the MMC-over-SPI driver

On Sat, May 24, 2008 at 1:56 PM, David Brownell <david-b@...bell.net> wrote:
> On Friday 23 May 2008, Anton Vorontsov wrote:
>>
>> This is second attempt to write the OpenFirmware bindings for the
>> MMC-over-SPI (and SPI bindings in general).
>
> Summary:  an OF-specific wrapper around the mmc_spi platform code.
>
> I think a wrapper to encapsulate all the OF-specific knowledge makes
> much sense here.
>
> The only thing that looks odd to me about this is that the wrapper
> is a spi_device rather than an of_device.  To me it makes more sense
> to just have an of_device setting up the right spi_device.  (Though
> maybe I missed some discussion about why that can't work.)

It's not so much that I can't work; more like it's not necessary.
of_platform bus is by no means the prescribed way to work with the
device tree.  In fact, there is talk about moving away from
of_platform bus entirely and using
platform_device/spi_device/i2c_device/etc directly instead since the
of_platform bus is mostly a clone of the platform bus with different
device binding semantics.

As Anton's patch shows, it is straight forward to add a binding that
can extract the platform data out of the device tree without the
overhead of adding an additional of_platform bus device & driver pair.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/