linux-kernel - Re: [PATCH 1/3] sched: fix TASK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080627204954.4CC04154226@magilla.localdomain>
Date:	Mon,  9 Jun 2008 14:10:50 -0700 (PDT)
From:	Roland McGrath <roland@...hat.com>
To:	Oleg Nesterov <oleg@...sign.ru>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Dmitry Adamushko <dmitry.adamushko@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Matthew Wilcox <matthew@....cx>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] sched: fix TASK_WAKEKILL vs SIGKILL race

I was also concerned about perturbing the schedule() hot path with the
original patch.  With this version making signal_pending_state() inline,
I think it's good.

> Note this "__TASK_STOPPED | __TASK_TRACED" check in signal_pending_state().
> This is needed to preserve the current behaviour (ptrace_notify). I hope
> this check will be removed soon, but this (afaics good) change needs the
> separate discussion.

Agreed.  I think it might actually already be safe to drop it, but we can
get to that after this settles.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/