linux-kernel - Re: [PATCH 7/7] fs/ocfs2/file.c: Release mutex in error handling code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080721203608.GB31671@ca-server1.us.oracle.com>
Date:	Mon, 21 Jul 2008 13:36:08 -0700
From:	Joel Becker <Joel.Becker@...cle.com>
To:	Julia Lawall <julia@...u.dk>
Cc:	mfasheh@...e.com, ocfs2-devel@....oracle.com,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 7/7] fs/ocfs2/file.c: Release mutex in error handling
	code

On Mon, Jul 21, 2008 at 09:59:15AM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@...u.dk>
> 
> The mutex is released on a successful return, so it would seem that it
> should be released on an error return as well.

	This patch looks right to me.  Mark?

Joel


-- 

"If you are ever in doubt as to whether or not to kiss a pretty girl, 
 give her the benefit of the doubt"
                                        -Thomas Carlyle

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@...cle.com
Phone: (650) 506-8127
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/