[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <48856741.6040606@goop.org>
Date: Mon, 21 Jul 2008 21:51:13 -0700
From: Jeremy Fitzhardinge <jeremy@...p.org>
To: Stephen Rothwell <sfr@...b.auug.org.au>
CC: Rusty Russell <rusty@...tcorp.com.au>, Ingo Molnar <mingo@...e.hu>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: fix pte_flags() to only return flags, fix lguest.
Stephen Rothwell wrote:
> Just a small point: You don't actually need the _AC() because this is
> already in a #ifndef __ASSEMBLY__ section of the file. But better safe
> than sorry, I guess. :-)
>
It's doubly wrong anyway. The correct thing to use here would be
_AT(pteval_t, 0x80....FFF), but even more correct to use PTE_MASK which
is already defined to have precisely this meaning.
J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists