linux-kernel - Re: [PATCH 1/5] docsrc: build Documentation/ sources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ea470500807300155t60732956m67d196f87aed9fa4@mail.gmail.com>
Date:	Wed, 30 Jul 2008 10:55:52 +0200
From:	"Boris Petkov" <petkovbb@...glemail.com>
To:	"Sam Ravnborg" <sam@...nborg.org>
Cc:	"Randy Dunlap" <rdunlap@...otime.net>,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH 1/5] docsrc: build Documentation/ sources

On Wed, Jul 30, 2008 at 10:44 AM, Sam Ravnborg <sam@...nborg.org> wrote:
> On Tue, Jul 29, 2008 at 10:27:32PM +0200, Borislav Petkov wrote:
>> On Tue, Jul 29, 2008 at 01:05:15PM -0700, Randy Dunlap wrote:
>> > From: Randy Dunlap <randy.dunlap@...cle.com>
>> >
>> > Currently source files in the Documentation/ sub-dir can easily bit-rot
>> > since they are not generally buildable, either because they are hidden
>> > in text files or because there are no Makefile rules for them.
>> > This needs to be fixed so that the source files remain usable and good
>> > examples of code instead of bad examples.
>> >
>> > Add the ability to build source files that are in the Documentation/ dir.
>> > Add to Kconfig as "BUILD_DOCSRC" config symbol.
>> >
>> > Use "CONFIG_BUILD_DOCSRC=1 make ..." to build objects from the
>> > Documentation/ sources.  Or enable BUILD_DOCSRC in the *config system.
>>
>> How about simply adding another makefile target instead? This is more
>> intuitive, imho, and complies with the Kbuild conventions so far.
>> Something like:
>>
>> make docsrc
>>
>> similar to 'make help' or 'make pdfdocs' etc.
>
> With the current approach we have much better build coverage.
> All "allyesconfig" and "allmodconfig" builds will do the test
> builds which is a good think.
> If we introduce "make docsrc" then almost only Randy will do the
> test builds and report the breakage - which is not good.

Well, i don't see anymore people than Randy doing

CONFIG_BUILD_DOCSRC=1 make ...

either so only the other option remains, which means CONFIG_BUILD_DOCSRC
should be "default y" for more coverage...


-- 
Regards/Gruß,
Boris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/