linux-kernel - Re: [PATCH 00/25] dyn_array and nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m18wve7gbt.fsf@frodo.ebiederm.org>
Date:	Sat, 02 Aug 2008 23:39:18 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	"Yinghai Lu" <yhlu.kernel@...il.com>
Cc:	"Ingo Molnar" <mingo@...e.hu>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Dhaval Giani" <dhaval@...ux.vnet.ibm.com>,
	"Mike Travis" <travis@....com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/25] dyn_array and nr_irqs support v3

"Yinghai Lu" <yhlu.kernel@...il.com> writes:

> On Sat, Aug 2, 2008 at 10:51 PM, Eric W. Biederman
> <ebiederm@...ssion.com> wrote:
>>
>> It appears that quite a few of the places you have changed are testing
>> to see if an irq is valid.  The idiomatic way to perform that test in
>> the kernel is:
>>
>> if (irq)
>
> is uninitialized irq to be -1 or 0?

0.  There is a long history behind it, but by decree of Linus and to conform
with reasonable intuition 0 is not a valid irq except in certain arch specific
corner cases.

>> With no test to see if you are >= NR_IRQS.
>>
>> I expect that is the change we want in the drivers that are performing such a
> silly
>> extra check.
>
> is_irq_valid(irq_no) ?
>
> wait to see your new patchset about dyn irq_cfg and irq_desc

I haven't promised one, at least not lately.  I went down a couple of
blind alleys and figured out what needed to be accomplished and then
ran out of steam about a year and a half 2 years ago, and I haven't
been able to get back to it.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/