linux-kernel - Re: [PATCH 00/25] dyn_array and nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440808022304g41749d9dn7688c81c3fdbed8a@mail.gmail.com>
Date:	Sat, 2 Aug 2008 23:04:18 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	"Ingo Molnar" <mingo@...e.hu>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Dhaval Giani" <dhaval@...ux.vnet.ibm.com>,
	"Mike Travis" <travis@....com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/25] dyn_array and nr_irqs support v3

On Sat, Aug 2, 2008 at 10:51 PM, Eric W. Biederman
<ebiederm@...ssion.com> wrote:
>
> It appears that quite a few of the places you have changed are testing
> to see if an irq is valid.  The idiomatic way to perform that test in
> the kernel is:
>
> if (irq)

is uninitialized irq to be -1 or 0?

>
> With no test to see if you are >= NR_IRQS.
>
> I expect that is the change we want in the drivers that are performing such a silly
> extra check.

is_irq_valid(irq_no) ?

wait to see your new patchset about dyn irq_cfg and irq_desc

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/