linux-kernel - Re: [PATCHv3] leds-pca955x: Add proper error handling and fix bogus memory handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 08 Aug 2008 11:49:30 -0500
From:	Nate Case <ncase@...-inc.com>
To:	Sven Wegener <sven.wegener@...aler.net>
Cc:	rpurdie@...ys.net, Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv3] leds-pca955x: Add proper error handling and fix
	bogus memory handling

On Fri, 2008-08-08 at 09:27 +0200, Sven Wegener wrote:
> Here's a slightly updated patch, with some changes I had forgotten.
> Shouldn't change the logic at all.
> 
> - Another 32 -> sizeof() conversion
> - Move the unregister code to where we also free the memory on failure
> 
> And one more
> 
> - cancel_work_sync() when unregistering on failure

This looks good to me.  I won't be able to test it until Monday though.

-- 
Nate Case <ncase@...-inc.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/