linux-kernel - Re: invalidate caches before going into suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877iak1z7z.fsf@basil.nowhere.org>
Date:	Wed, 13 Aug 2008 21:39:28 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Mark Langsdorf <mark.langsdorf@....com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: invalidate caches before going into suspend

Mark Langsdorf <mark.langsdorf@....com> writes:
> @@ -93,11 +93,11 @@ static inline void play_dead(void)
>  static inline void play_dead(void)
>  {
>  	idle_task_exit();
> -	wbinvd();
>  	mb();
>  	/* Ack it */
>  	__get_cpu_var(cpu_state) = CPU_DEAD;
>  
> +	wbinvd();

You should put the mb() (or just a barrier()) directly above the wbinvd(), 
otherwise the compiler is free to reorder this behind your back again
and move the store down after the wbinvd.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/