[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <48C2B90C.8000205@colorfullife.com>
Date: Sat, 06 Sep 2008 19:08:28 +0200
From: Manfred Spraul <manfred@...orfullife.com>
To: Ingo Molnar <mingo@...e.hu>
CC: linux-kernel@...r.kernel.org, paulmck@...ux.vnet.ibm.com,
akpm@...ux-foundation.org
Subject: Re: [PATCH] kernel/cpu.c: Move the CPU_DYING notifiers
Ingo Molnar wrote:
> * Manfred Spraul <manfred@...orfullife.com> wrote:
>
>> - raw_notifier_call_chain(&cpu_chain, CPU_DYING | param->mod,
>> - param->hcpu);
>> /* Ensure this CPU doesn't handle any more interrupts. */
>> err = __cpu_disable();
>> if (err < 0)
>> return err;
>>
>> + raw_notifier_call_chain(&cpu_chain, CPU_DYING | param->mod,
>> + param->hcpu);
>>
>
> hm, doesnt this break things like CPU cross-calls done in CPU_DYING
> callbacks?
>
We are within stop_machine(). No other cpu is running. As fas as I can
see no cross-calls are possible.
Which scenario do you think about?
--
Manfred
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists