linux-kernel - Re: [PATCH] dyn_array: using %pF instead of print_fn_descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080906170944.GG4856@elte.hu>
Date:	Sat, 6 Sep 2008 19:09:44 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Yinghai Lu <yhlu.kernel@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dyn_array: using %pF instead of
	print_fn_descriptor_symbol


* Andrew Morton <akpm@...ux-foundation.org> wrote:

> >	ptr = __alloc_bootmem_nopanic(total_size, max_align, 0);
> >	if (!ptr)
> >		panic("Can not alloc dyn_alloc\n");
> 
> Why duplicate the panic()?  Just call __alloc_bootmem().

agreed.

> > #ifdef CONFIF_GENERIC_HARDIRQS
> 
> That doesn't appear to have been very well tested?

on non-genirq systems? Most likely. If then most testing they get is 
from cross-build tools. Few if any actual users.

> The code has a few coding-style glitches which checkpatch can detect.

yeah. Yinghai, could you please fix them?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/