[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080906171345.GH4856@elte.hu>
Date: Sat, 6 Sep 2008 19:13:45 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Manfred Spraul <manfred@...orfullife.com>
Cc: linux-kernel@...r.kernel.org, paulmck@...ux.vnet.ibm.com,
akpm@...ux-foundation.org
Subject: Re: [PATCH] kernel/cpu.c: Move the CPU_DYING notifiers
* Manfred Spraul <manfred@...orfullife.com> wrote:
> Ingo Molnar wrote:
>> * Manfred Spraul <manfred@...orfullife.com> wrote:
>>
>>> - raw_notifier_call_chain(&cpu_chain, CPU_DYING | param->mod,
>>> - param->hcpu);
>>> /* Ensure this CPU doesn't handle any more interrupts. */
>>> err = __cpu_disable();
>>> if (err < 0)
>>> return err;
>>> + raw_notifier_call_chain(&cpu_chain, CPU_DYING | param->mod,
>>> + param->hcpu);
>>>
>>
>> hm, doesnt this break things like CPU cross-calls done in CPU_DYING
>> callbacks?
>>
>
> We are within stop_machine(). No other cpu is running. As fas as I can
> see no cross-calls are possible.
ah, ok - my bad. I was confusing it with the much more common
CPU_DOWN_PREPARE type of callbacks which do use various cross-CPU APIs.
applied to tip/sched/devel, thanks Manfred!
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists