linux-kernel - Re: [PATCH] Add missing macro argument for devm_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080906.081841.03994201.Hiroshi.DOYU@nokia.com>
Date:	Sat, 06 Sep 2008 08:18:41 +0300 (EEST)
From:	Hiroshi DOYU <Hiroshi.DOYU@...ia.com>
To:	akpm@...ux-foundation.org
Cc:	linux-kernel@...r.kernel.org, tony@...mide.com
Subject: Re: [PATCH] Add missing macro argument for devm_release_* family

From: "ext Andrew Morton" <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Add missing macro argument for devm_release_* family
Date: Fri, 5 Sep 2008 18:52:54 -0700

> On Sat,  6 Sep 2008 04:00:23 +0300 Hiroshi DOYU <Hiroshi.DOYU@...ia.com> wrote:
> 
> > From: ext Hiroshi DOYU <Hiroshi.DOYU@...ia.com>
> > 
> > Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@...ia.com>
> > ---
> >  include/linux/ioport.h |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/linux/ioport.h b/include/linux/ioport.h
> > index 22d2115..c813c63 100644
> > --- a/include/linux/ioport.h
> > +++ b/include/linux/ioport.h
> > @@ -158,9 +158,9 @@ extern struct resource * __devm_request_region(struct device *dev,
> >  				struct resource *parent, resource_size_t start,
> >  				resource_size_t n, const char *name);
> >  
> > -#define devm_release_region(start,n) \
> > +#define devm_release_region(dev,start,n) \
> >  	__devm_release_region(dev, &ioport_resource, (start), (n))
> > -#define devm_release_mem_region(start,n) \
> > +#define devm_release_mem_region(dev,start,n) \
> >  	__devm_release_region(dev, &iomem_resource, (start), (n))
> >  
> >  extern void __devm_release_region(struct device *dev, struct resource *parent,
> 
> um, OK.
> 
> But none of these things appear to have any callers anywhere.  Why
> don't we just delete it all?

Not sure for others, but at least, I am using this in my developing
driver;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/