linux-kernel - Re: [PATCH 1/2] cgroups: enhance task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6599ad830811211058q3fe12e5coa62436e777b60f1a@mail.gmail.com>
Date:	Fri, 21 Nov 2008 10:58:44 -0800
From:	Paul Menage <menage@...gle.com>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Containers <containers@...ts.linux-foundation.org>
Subject: Re: [PATCH 1/2] cgroups: enhance task_cgroup()

On Fri, Nov 21, 2008 at 12:49 AM, Lai Jiangshan <laijs@...fujitsu.com> wrote:
>
> task_cgroup() calls cgroup_subsys_state().

No, it calls task_subsys_state()

> and we must use rcu_read_lock() to protect cgroup_subsys_state().
> so we must use rcu_read_lock() to protect task_cgroup().
>
> but it'll not so friendly to caller: the callers of task_cgroup() have
> held cgroup_lock(). it means that struct cgroup will not be freed.
>
> So this patch add rcu_read_lock() in task_cgroup() to enhance task_cgroup().
> And we do NOT NEED FIX task_cgroup()'s callers, and cgroup_lock()
> can protect task_cgroup().

Is there a reason to add an implicit rcu_read_lock() in task_cgroup()
and not directly in task_subsys_state() ?

Paul

>
> Signed-off-by: Lai Jiangshan <laijs@...fujitsu.com>
> ---
> diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
> index 1164963..22901ff 100644
> --- a/include/linux/cgroup.h
> +++ b/include/linux/cgroup.h
> @@ -359,6 +360,10 @@
>  static inline struct cgroup* task_cgroup(struct task_struct *task,
>                                               int subsys_id)
>  {
> -       return task_subsys_state(task, subsys_id)->cgroup;
> +       struct cgroup *ret;
> +       rcu_read_lock();
> +       ret = task_subsys_state(task, subsys_id)->cgroup;
> +       rcu_read_unlock();
> +       return ret;
>  }
>
>  int cgroup_clone(struct task_struct *tsk, struct cgroup_subsys *ss,
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/