linux-kernel - Re: [PATCH] x86: clean up setup_clear/force_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081228094605.GE9022@elte.hu>
Date:	Sun, 28 Dec 2008 10:46:05 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Yinghai Lu <yinghai@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: clean up setup_clear/force_cpu_cap handling


* Rusty Russell <rusty@...tcorp.com.au> wrote:

> On Saturday 27 December 2008 20:52:34 Ingo Molnar wrote:
> > 
> > * Yinghai Lu <yinghai@...nel.org> wrote:
> > 
> > > Impact: fix and cleanup
> > > 
> > > setup_force_cpu_cap() only have one user xen
> > > but it should not reuse cleared_cpu_cpus. it will have problem
> > > for smp.
> > > 
> > > need to have cpu_cpus_set array too.
> > > also need to setup handling before all cpus cap AND
> > > 
> > > Signed-off-by: Yinghai Lu <yinghai.lu@...nel.org>
> > > 
> > > ---
> > >  arch/x86/include/asm/cpufeature.h |    4 ++--
> > >  arch/x86/include/asm/processor.h  |    3 ++-
> > >  arch/x86/kernel/cpu/common.c      |   17 ++++++++++++-----
> > >  3 files changed, 16 insertions(+), 8 deletions(-)
> > 
> > Rusty, you'll carry this patch in your linux-2.6-boot-params.git tree, 
> > right? Merging this in the x86 tree would just needlessly complicate your 
> > logistics, right?
> 
> Yep, if you're happy to ack, I'm happy to carry.

yeah. And if it breaks, that's your fault ;-)

Acked-by: Ingo Molnar <mingo@...e.hu>

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/