linux-kernel - Re: cpumask change causes sparc build bustage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090111.040640.188129980.davem@davemloft.net>
Date:	Sun, 11 Jan 2009 04:06:40 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sfr@...b.auug.org.au
Cc:	linux-kernel@...r.kernel.org, sparclinux@...r.kernel.org,
	travis@....com, mingo@...e.hu
Subject: Re: cpumask change causes sparc build bustage

From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Sun, 11 Jan 2009 20:50:08 +1100

> On Sun, 11 Jan 2009 00:31:03 -0800 (PST) David Miller <davem@...emloft.net> wrote:
> >
> > I'm surprised linux-next builds didn't catch this.
> 
> So am I.  http://kisskb.ellerman.id.au/kisskb/compiler/5/ shows my latest
> builds of both linux-next and Linus' tree are OK for defconfig and
> allnoconfig (allmodconfig fails for a different reason).
> 
> What is different about the failing config (compiler)?  Are there other
> configs it would be sensible to build test?

Maybe you don't have NUMA enabled in the test build configs.
I hit it during an allmodconfig.

Anyways this fixes it, someone please apply:

sparc64: Fix cpumask related build failure.

Signed-off-by: David S. Miller <davem@...emloft.net>

diff --git a/arch/sparc/include/asm/topology_64.h b/arch/sparc/include/asm/topology_64.h
index b8a65b6..5bc0b8f 100644
--- a/arch/sparc/include/asm/topology_64.h
+++ b/arch/sparc/include/asm/topology_64.h
@@ -47,6 +47,10 @@ static inline int pcibus_to_node(struct pci_bus *pbus)
 	(pcibus_to_node(bus) == -1 ? \
 	 CPU_MASK_ALL : \
 	 node_to_cpumask(pcibus_to_node(bus)))
+#define cpumask_of_pcibus(bus)	\
+	(pcibus_to_node(bus) == -1 ? \
+	 CPU_MASK_ALL_PTR : \
+	 cpumask_of_node(pcibus_to_node(bus)))
 
 #define SD_NODE_INIT (struct sched_domain) {		\
 	.min_interval		= 8,			\
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/