linux-kernel - Re: checkpatch warning of struct indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c62985530901121009h372c805dj14c748c8f266235d@mail.gmail.com>
Date:	Mon, 12 Jan 2009 19:09:00 +0100
From:	"Frédéric Weisbecker" <fweisbec@...il.com>
To:	"Steven Rostedt" <rostedt@...dmis.org>
Cc:	"Andy Whitcroft" <apw@...onical.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"Ingo Molnar" <mingo@...e.hu>,
	"Andrew Morton" <akpm@...ux-foundation.org>
Subject: Re: checkpatch warning of struct indentation

2009/1/12 Steven Rostedt <rostedt@...dmis.org>:
>
> Hi,
>
> I'm now seeing the following warnings from checkpatch:
>
> #325: FILE: kernel/trace/trace_stat.c:21:
> +       void                    *stat;
>
> ERROR: "foo     *bar" should be "foo *bar"
> #334: FILE: kernel/trace/trace_stat.c:27:
> +       struct tracer_stat      *ts;
>
> ERROR: "foo             *bar" should be "foo    *bar"
> #337: FILE: kernel/trace/trace_stat.c:30:
> +       struct dentry           *file;


Oh my patch :-)
Yeah I had the same errors when I checked it. I ignored them because
I because I remembered checkpatch.pl didn't warn about such things before.
And it seems to warn about such statements since very recently...


> This is for:
>
> struct tracer_stat_session {
>        struct list_head        session_list;
>        struct tracer_stat      *ts;
>        struct list_head        stat_list;
>        struct mutex            stat_mutex;
>        struct dentry           *file;
> };
>
> Which looks a hell of a lot better than:
>
> struct tracer_stat_session {
>        struct list_head session_list;
>        struct tracer_stat *ts;
>        struct list_head stat_list;
>        struct mutex stat_mutex;
>        struct dentry *file;
> };
>
> We probably do not want to warn on such things.
>
> -- Steve
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/