linux-kernel - Re: checkpatch warning of struct indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Jan 2009 19:20:38 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Andy Whitcroft <apw@...onical.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: checkpatch warning of struct indentation


* Steven Rostedt <rostedt@...dmis.org> wrote:

> Hi,
> 
> I'm now seeing the following warnings from checkpatch:
> 
> #325: FILE: kernel/trace/trace_stat.c:21:
> +	void 			*stat;
> 
> ERROR: "foo 	*bar" should be "foo *bar"
> #334: FILE: kernel/trace/trace_stat.c:27:
> +	struct tracer_stat 	*ts;
> 
> ERROR: "foo		*bar" should be "foo	*bar"
> #337: FILE: kernel/trace/trace_stat.c:30:
> +	struct dentry		*file;
> 
> This is for:
> 
> struct tracer_stat_session {
>         struct list_head        session_list;
>         struct tracer_stat      *ts;
>         struct list_head        stat_list;
>         struct mutex            stat_mutex;
>         struct dentry           *file;
> };
> 
> Which looks a hell of a lot better than:
> 
> struct tracer_stat_session {
>         struct list_head session_list;
>         struct tracer_stat *ts;
>         struct list_head stat_list;
>         struct mutex stat_mutex;
>         struct dentry *file;
> };
> 
> We probably do not want to warn on such things.

yeah, those warnings look bogus.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/